[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <54B6A54A.1050601@osg.samsung.com>
Date: Wed, 14 Jan 2015 10:20:10 -0700
From: Shuah Khan <shuahkh@....samsung.com>
To: Michael Ellerman <mpe@...erman.id.au>
CC: linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests
On 01/13/2015 07:15 PM, Michael Ellerman wrote:
> On Tue, 2015-01-13 at 17:16 -0700, Shuah Khan wrote:
>> Please add a commit log.
>
> What does it need to say?
Explain the change the patch is making. Please see
Documentation/SubmittingPatches for details.
Looks like this patch is no longer needed as I see a new
patch added to the series from Anshuman Khandual.
>
>> On 01/13/2015 04:49 PM, Michael Ellerman wrote:
>>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>>> ---
>>> .../testing/selftests/powerpc/copyloops/.gitignore | 4 ++++
>>> tools/testing/selftests/powerpc/mm/.gitignore | 1 +
>>> tools/testing/selftests/powerpc/pmu/.gitignore | 3 +++
>>> tools/testing/selftests/powerpc/pmu/ebb/.gitignore | 22 ++++++++++++++++++++++
>>> .../selftests/powerpc/primitives/.gitignore | 1 +
>>> tools/testing/selftests/powerpc/tm/.gitignore | 1 +
>>> 6 files changed, 32 insertions(+)
>>> create mode 100644 tools/testing/selftests/powerpc/copyloops/.gitignore
>>> create mode 100644 tools/testing/selftests/powerpc/mm/.gitignore
>>> create mode 100644 tools/testing/selftests/powerpc/pmu/.gitignore
>>> create mode 100644 tools/testing/selftests/powerpc/pmu/ebb/.gitignore
>>> create mode 100644 tools/testing/selftests/powerpc/primitives/.gitignore
>>> create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore
>>
>> Please create a single .gitignore for all targets right under
>> tools/testing/selftests/powerpc instead of multiple .gitignore
>> files.
>
> Why? Having separate files makes it less likely we'll get merge conflicts
> between different test subdirectores, it also makes it more likely someone
> adding a test will notice they need to update the .gitignore in the same
> directory.
>
It is a matter of reducing the number of files. I am fine with creating
one per directory, if that fits in better with powerpc tests.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists