linux-kernel - Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150114122329.40464fd2@gandalf.local.home>
Date:	Wed, 14 Jan 2015 12:23:29 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Wang Nan <wangnan0@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	mingo@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	paulmck@...ux.vnet.ibm.com, mathieu.desnoyers@...icios.com,
	xiakaixu 00238161 <xiakaixu@...wei.com>
Subject: Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after
 rcu_init()

On Wed, 14 Jan 2015 10:09:05 +0900
Namhyung Kim <namhyung@...nel.org> wrote:


> > >> +
> > >> +void __init trace_event_init(void)
> > >> +{
> > >> +	event_trace_memsetup();
> > >> +	init_ftrace_syscalls();
> > >> +	event_trace_enable();
> > >> +}
> > >> +
> > > 
> > > init_ftrace_syscalls() get called twice by trace_init() and trace_event_init(), some resources are wasted.
> > > At lease one of them can be removed.
> 
> I think it's more natural to keep it in the trace_event_init().

I agree, I'll remove it. I'm fixing another bug that this change caused
to system call events.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/