linux-kernel - Re: [PATCH 2/3] leds: leds-mc13783: Use of_get_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-K2aKzSFB__bJ5Znd=-iYbHJX7JkBmiH9ndf9S4kNs+9g@mail.gmail.com>
Date:	Wed, 14 Jan 2015 10:42:59 -0800
From:	Bryan Wu <cooloney@...il.com>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Jingoo Han <jg1.han@...sung.com>,
	Lee Jones <lee.jones@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>
Subject: Re: [PATCH 2/3] leds: leds-mc13783: Use of_get_child_by_name()
 instead of refcount hack

On Wed, Jan 14, 2015 at 5:51 AM, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
> of_find_node_by_name() calls of_node_put() on its "from" parameter.
> To counter this, mc13xxx_led_probe_dt() calls of_node_get() first.
>
> Use of_get_child_by_name() instead to get rid of the refcount hack.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: linux-leds@...r.kernel.org

Looks good, applied to my tree.
Thanks,
-Bryan


> ---
> Compile-tested only
> ---
>  drivers/leds/leds-mc13783.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index 85c3714e1b5aabba..e2b847fe22a1c934 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c
> @@ -134,9 +134,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
>         if (!pdata)
>                 return ERR_PTR(-ENOMEM);
>
> -       of_node_get(dev->parent->of_node);
> -
> -       parent = of_find_node_by_name(dev->parent->of_node, "leds");
> +       parent = of_get_child_by_name(dev->parent->of_node, "leds");
>         if (!parent)
>                 goto out_node_put;
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/