linux-kernel - Re: [PATCH] block: pass correct prot_buf pointer to integrity metadata processing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq161c9w1rn.fsf@sermon.lab.mkp.net>
Date:	Wed, 14 Jan 2015 15:22:36 -0500
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Sam Bradshaw <sbradshaw@...ron.com>
Cc:	<martin.petersen@...cle.com>, <axboe@...nel.dk>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: pass correct prot_buf pointer to integrity metadata processing function

>>>>> "Sam" == Sam Bradshaw <sbradshaw@...ron.com> writes:

Hey Sam,

Sam> The prot_buf pointer passed to the generate/verify functions is
Sam> incorrect for the second and subsequent range, making it impossible
Sam> to verify the guard tag.  The patch correctly increments the
Sam> prot_buf pointer by the tuple size for each pass.

prot_buf is just a temporary variable used to get the kernel address of
the buffer pointer. We only care about iter.prot_buf and that gets
incremented by the generate or verify functions.

Are your data buffers page aligned? Things are going to break if they
aren't...

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/