linux-kernel - Re: [PATCH] gpu: drm: radeon: radeon_object: Remove unused function

Open Source and information security mailing list archives

Message-ID: <CADnq5_O0eJmMD+c4QqsfNh4gG+K5nqHjnY6V0r-qyS++-1OOwQ@mail.gmail.com>
Date:	Wed, 14 Jan 2015 16:43:46 -0500
From:	Alex Deucher <alexdeucher@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] gpu: drm: radeon: radeon_object: Remove unused function

On Sun, Jan 11, 2015 at 8:17 AM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Remove the function radeon_bo_fbdev_mmap() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_object.c |    6 ------
>  drivers/gpu/drm/radeon/radeon_object.h |    2 --
>  2 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 99a960a..4f2515f 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -542,12 +542,6 @@ int radeon_bo_list_validate(struct radeon_device *rdev,
>         return 0;
>  }
>
> -int radeon_bo_fbdev_mmap(struct radeon_bo *bo,
> -                            struct vm_area_struct *vma)
> -{
> -       return ttm_fbdev_mmap(vma, &bo->tbo);
> -}
> -
>  int radeon_bo_get_surface_reg(struct radeon_bo *bo)
>  {
>         struct radeon_device *rdev = bo->rdev;
> diff --git a/drivers/gpu/drm/radeon/radeon_object.h b/drivers/gpu/drm/radeon/radeon_object.h
> index 1b8ec79..1cf3cd9 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.h
> +++ b/drivers/gpu/drm/radeon/radeon_object.h
> @@ -143,8 +143,6 @@ extern void radeon_bo_fini(struct radeon_device *rdev);
>  extern int radeon_bo_list_validate(struct radeon_device *rdev,
>                                    struct ww_acquire_ctx *ticket,
>                                    struct list_head *head, int ring);
> -extern int radeon_bo_fbdev_mmap(struct radeon_bo *bo,
> -                               struct vm_area_struct *vma);
>  extern int radeon_bo_set_tiling_flags(struct radeon_bo *bo,
>                                 u32 tiling_flags, u32 pitch);
>  extern void radeon_bo_get_tiling_flags(struct radeon_bo *bo,
> --
> 1.7.10.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives