linux-kernel - Re: [PATCH v2] drm/panel: Add support for AUO b101ean01 panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS+omA5bNBW8NfE2Y7NtW6o5ubCZGUcYyZxFjiJ3MHaNKNQ5g@mail.gmail.com>
Date:	Thu, 15 Jan 2015 15:40:55 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	huang lin <hl@...k-chips.com>
Cc:	Douglas Anderson <dianders@...omium.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Thierry Reding <thierry.reding@...il.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/panel: Add support for AUO b101ean01 panel

Hi hl,

On Thu, Jan 15, 2015 at 2:15 PM, huang lin <hl@...k-chips.com> wrote:
> The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> which can be supported by the simple panel driver.
>
> Signed-off-by: huang lin <hl@...k-chips.com>
>
> ---
>
> Changes in v2:
> - changed panel timing
>
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index e95385b..c02f0e6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -392,6 +392,29 @@ static const struct panel_desc auo_b116xw03 = {
>         },
>  };
>
> +static const struct drm_display_mode auo_b101ean01_mode = {

Perhaps you missed my last review where I suggested moving the
definitions for auo_b101ean01 under auo_b101aw03.
With that change, this patch is

Reviewed-by: Daniel Kurtz <djkurtz@...omium.org>

> +       .clock = 72500,
> +       .hdisplay = 1280,
> +       .hsync_start = 1280 + 147,
> +       .hsync_end = 1280 + 147 + 32,
> +       .htotal = 1280 + 147 + 32 + 21,
> +       .vdisplay = 800,
> +       .vsync_start = 800 + 4,
> +       .vsync_end = 800 + 4 + 4,
> +       .vtotal = 800 + 4 + 4 + 8,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_desc auo_b101ean01 = {
> +       .modes = &auo_b101ean01_mode,
> +       .num_modes = 1,
> +       .bpc = 6,
> +       .size = {
> +               .width = 217,
> +               .height = 136,
> +       },
> +};
> +
>  static const struct drm_display_mode auo_b133xtn01_mode = {
>         .clock = 69500,
>         .hdisplay = 1366,
> @@ -727,6 +750,9 @@ static const struct of_device_id platform_of_match[] = {
>                 .compatible = "auo,b101aw03",
>                 .data = &auo_b101aw03,
>         }, {
> +               .compatible = "auo,b101ean01",
> +               .data = &auo_b101ean01,
> +       }, {
>                 .compatible = "auo,b101xtn01",
>                 .data = &auo_b101xtn01,
>         }, {
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/