linux-kernel - Re: [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Jan 2015 13:26:47 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	LFBDEV <linux-fbdev@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()

On 12/01/15 21:21, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  drivers/video/fbdev/ssd1307fb.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index a7ecaa6..c891f11 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
>  	return ret;
>  }
>  
> -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
> -{
> -	struct ssd1307fb_array *array;
> -	int ret;
> -
> -	array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
> -	if (!array)
> -		return -ENOMEM;
> -
> -	array->data[0] = data;
> -
> -	ret = ssd1307fb_write_array(client, array, 1);
> -	kfree(array);
> -
> -	return ret;
> -}
> -
>  static void ssd1307fb_update_display(struct ssd1307fb_par *par)
>  {
>  	struct ssd1307fb_array *array;
> 

Thanks, queued for 3.20.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)