linux-kernel - Re: [RFC PATCH] NFC: st21nfcb: Avoid use of skb after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B8323D.6020304@gmail.com>
Date:	Thu, 15 Jan 2015 22:33:49 +0100
From:	"christophe.ricard" <christophe.ricard@...il.com>
To:	Anda-Maria Nicolae <anda-maria.nicolae@...el.com>,
	lauro.venancio@...nbossa.org, aloisio.almeida@...nbossa.org,
	sameo@...ux.intel.com, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] NFC: st21nfcb: Avoid use of skb after free

Hi Anda-Maria,

I agree with your fix. I have built and tested it successfully.
I will include it in a new patch series with a:
Acked-by: Christophe Ricard <christophe-h.ricard@...com>

Thanks a lot.
Christophe
On 15/01/2015 11:30, Anda-Maria Nicolae wrote:
> Do not insert in send queue the skb that contains unknown Packet Control Byte
>
> Signed-off-by: Anda-Maria Nicolae <anda-maria.nicolae@...el.com>
> ---
> Only compile tested, please have a look
>
>   drivers/nfc/st21nfcb/ndlc.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/st21nfcb/ndlc.c b/drivers/nfc/st21nfcb/ndlc.c
> index bac50e8..72659a3 100644
> --- a/drivers/nfc/st21nfcb/ndlc.c
> +++ b/drivers/nfc/st21nfcb/ndlc.c
> @@ -138,7 +138,7 @@ static void llt_ndlc_requeue_data_pending(struct llt_ndlc *ndlc)
>   		default:
>   			pr_err("UNKNOWN Packet Control Byte=%d\n", pcb);
>   			kfree_skb(skb);
> -			break;
> +			continue;
>   		}
>   		skb_queue_head(&ndlc->send_q, skb);
>   	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/