linux-kernel - [tip:x86/cleanups] x86, early_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-b34630014dad0ba69aadd8deb231ddc6d2efcf53@git.kernel.org>
Date:	Fri, 16 Jan 2015 00:07:41 -0800
From:	tip-bot for Alexander Kuleshov <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	bp@...e.de, hpa@...or.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	kuleshovmail@...il.com
Subject: [tip:x86/cleanups] x86, early_serial_console:
  Remove unnecessary check

Commit-ID:  b34630014dad0ba69aadd8deb231ddc6d2efcf53
Gitweb:     http://git.kernel.org/tip/b34630014dad0ba69aadd8deb231ddc6d2efcf53
Author:     Alexander Kuleshov <kuleshovmail@...il.com>
AuthorDate: Wed, 31 Dec 2014 13:12:38 +0600
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Tue, 13 Jan 2015 12:14:44 +0100

x86, early_serial_console: Remove unnecessary check

We do this check already a couple of lines up.

Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
Link: http://lkml.kernel.org/r/1420009958-4803-1-git-send-email-kuleshovmail@gmail.com
Signed-off-by: Borislav Petkov <bp@...e.de>
---
 arch/x86/boot/early_serial_console.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 790586d..45a0768 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -72,8 +72,8 @@ static void parse_earlyprintk(void)
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
 
-			if (!strncmp(arg + pos, "ttyS", 4))
-				pos += 4;
+			/* += strlen("ttyS"); */
+			pos += 4;
 
 			if (arg[pos++] == '1')
 				idx = 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/