linux-kernel - Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150116083433.GZ26817@axis.com>
Date:	Fri, 16 Jan 2015 09:34:33 +0100
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Jesper Nilsson <jespern@...s.com>,
	"viro@...IV.linux.org.uk" <viro@...IV.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-cris-kernel <linux-cris-kernel@...s.com>
Subject: Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()
 [ver #2]

On Tue, Jan 13, 2015 at 06:57:53PM +0100, David Howells wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
> 
> Found with: git grep '[.>]f_dentry'

Yes, compile works with this patch. Do you want me to take it through
the CRIS tree or do you have any other tree in mind?

> Signed-off-by: David Howells <dhowells@...hat.com>

In any case:

Reviewed-by: Jesper Nilsson <jesper.nilsson@...s.com>

>  arch/cris/arch-v32/drivers/sync_serial.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
> index 08a313fc2241..f772068d9e79 100644
> --- a/arch/cris/arch-v32/drivers/sync_serial.c
> +++ b/arch/cris/arch-v32/drivers/sync_serial.c
> @@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
>  				  struct timespec *ts)
>  {
>  	unsigned long flags;
> -	int dev = MINOR(file->f_dentry->d_inode->i_rdev);
> +	int dev = MINOR(file_inode(file)->i_rdev);
>  	int avail;
>  	struct sync_port *port;
>  	unsigned char *start;
> 

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/