linux-kernel - Re: [PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B920FC.8090905@roeck-us.net>
Date:	Fri, 16 Jan 2015 06:32:28 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Athira Lekshmi <andnlnbn18@...il.com>, wim@...ana.be
CC:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning

On 01/15/2015 07:31 AM, Athira Lekshmi wrote:
> Add a new line after declarations to remove the checkpatch warning:
> 'Missing blank line after declarations'
>
> Signed-off-by: Athira Lekshmi <andnlnbn18@...il.com>
> ---
> Changes in v2:
>    -  Make the commit message more clearer.
>

The patches are all good, though I would suggest something like
"Add missing blank lines" as subject, and I would suggest to merge
the 8 watchdog patches into one.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/