linux-kernel - Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Jan 2015 11:07:43 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Jia He <hejianet@...il.com>
Cc:	linux-kernel@...r.kernel.org, Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about
 static  declaration

Jia He,

Your patch is looking better :-)
A few nits though.

On Fri, Jan 16, 2015 at 04:58:12PM +0800, Jia He wrote:
>   These functions kportal_memhog_{alloc,free} aren't used outside of 
^^^^^ Don't indent paragraphs, just use a line between paragraphs.
> this file, so making them static to suppress the sparse warnings about 
> static declaration.

>   Besides, this also fixes the space warning checked by checkpatch.pl
"Besides" doesn't sound right here.  I would just say something like
"Also fix the space warning ..."

In your subject line it is helpful to add a version number so people
can tell that this is a new revision.  For example: [PATCH v2].
git format-patch can add this automatically with the '-v' option.

[...]

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/