linux-kernel - Re: [PATCH] coresight: remove the unnecessary function coresight_is_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLsYkzr28AwAP6eX4VZp-Uf5N_jJf2gmc-ks4KXwc3QEcCscg@mail.gmail.com>
Date:	Fri, 16 Jan 2015 13:13:38 -0700
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	Kaixu Xia <xiakaixu@...wei.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Kaixu Xia <kaixu.xia@...aro.org>
Subject: Re: [PATCH] coresight: remove the unnecessary function coresight_is_bit_set()

On 15 January 2015 at 05:26, Kaixu Xia <xiakaixu@...wei.com> wrote:
> This function coresight_is_bit_set() isn't called, so we should
> remove it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@...wei.com>
> ---
>  include/linux/coresight.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 5d3c543..a860933 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -236,7 +236,6 @@ coresight_register(struct coresight_desc *desc);
>  extern void coresight_unregister(struct coresight_device *csdev);
>  extern int coresight_enable(struct coresight_device *csdev);
>  extern void coresight_disable(struct coresight_device *csdev);
> -extern int coresight_is_bit_set(u32 val, int position, int value);
>  extern int coresight_timeout(void __iomem *addr, u32 offset,
>                              int position, int value);
>  #ifdef CONFIG_OF
> @@ -250,8 +249,6 @@ static inline void coresight_unregister(struct coresight_device *csdev) {}
>  static inline int
>  coresight_enable(struct coresight_device *csdev) { return -ENOSYS; }
>  static inline void coresight_disable(struct coresight_device *csdev) {}
> -static inline int coresight_is_bit_set(u32 val, int position, int value)
> -                                        { return 0; }
>  static inline int coresight_timeout(void __iomem *addr, u32 offset,
>                                      int position, int value) { return 1; }
>  #ifdef CONFIG_OF
> --
> 1.8.5.5
>

Applied - thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/