linux-kernel - Re: [PATCH] clk-gate: fix bit # check in clk_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54BADCFB.5010805@cogentembedded.com>
Date:	Sun, 18 Jan 2015 01:06:51 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org, sboyd@...eaurora.org
CC:	linux-sh@...r.kernel.org
Subject: Re: [PATCH] clk-gate: fix bit # check in clk_register_gate()

Hello.

On 01/18/2015 01:01 AM, Mike Turquette wrote:

>> In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit #
>> should be no higher than 15, however the corresponding check is obviously off-
>> by-one.

>> Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

> Applied to clk-next. Thanks! Is this causing a visible regression for
> you? It is not a new bug so I'd prefer to send it though clk-next unless
> something is blowing up on your end.

    No, nothing, I don't even call this function (was using composite clock). 
Found by just looking at the code.

>> ---
>> The patch is against Linus' repo because the 'clk-fixes' branch  in  Mike
>> Turquette's 'linux.git' repo at Linaro seems very outdated. BTW, the repo
>> at kernel.org specified by the MAINTAINERS file doesn't seem to exist --
>> can something be done about that?

> The clk-fixes branch at git.linaro.org is now updated and the clk tree
> at git.kernel.org is also live. Blame the holidays.

> For now they will mirror each other (and linux-next will continue to
> reference the one at git.linaro.org until 3.19 is released).

    Thank you.

> Regards,
> Mike

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/