lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150117230355.GB9418@kroah.com>
Date:	Sat, 17 Jan 2015 15:03:55 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Simone Weiss <simone.weiss@....de>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...cs.fau.de,
	lidza.louina@...il.com, driverdev-devel@...uxdriverproject.org,
	helene.gsaenger@...dium.fau.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] dgnc/dpacompat.h: checkpatch: fixed long lines bei
 moving comments

On Mon, Dec 22, 2014 at 02:17:31AM +0100, Simone Weiss wrote:
> 
> Signed-off-by: Simone Weiss <simone.weiss@....de>
> Signed-off-by: Helene Gsaenger <helene.gsaenger@...dium.fau.de>
> ---
>  drivers/staging/dgnc/dpacompat.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
> index b2d2dc0..feb4f60 100644
> --- a/drivers/staging/dgnc/dpacompat.h
> +++ b/drivers/staging/dgnc/dpacompat.h
> @@ -111,5 +111,7 @@ struct ni_info {
>  #define DIGI_GET_NI_INFO ('d'<<8) | 250		/* nonintelligent state snfo */
>  
>  /* Other special ioctls */
> -#define DIGI_TIMERIRQ ('d'<<8) | 251		/* Enable/disable RS_TIMER use */
> -#define DIGI_LOOPBACK ('d'<<8) | 252		/* Enable/disable UART internal loopback */
> +#define DIGI_TIMERIRQ ('d'<<8) | 251		/* Enable/disable
> +						 * RS_TIMER use */
> +#define DIGI_LOOPBACK ('d'<<8) | 252		/* Enable/disable UART
> +						 * internal loopback */
> -- 
> 1.9.1

That really doesn't look better, does it?

Please resend a fixed up series, I'm too confused by all of the
different patches you have sent to figure out what to apply.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ