linux-kernel - Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Jan 2015 15:09:40 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Shirish Gajera <gajerashirish@...il.com>
Cc:	eric.rost@...abylon.net, jason@...edaemon.net, jake@....net,
	antonysaraev@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from
 single statement.

On Sun, Jan 11, 2015 at 03:41:05PM -0800, Shirish Gajera wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: Single statement macros should not use a do {} while (0) loop
> 
> I remove do while from the single statement macro.
> 
> Signed-off-by: Shirish Gajera <gajerashirish@...il.com>
> ---
>  drivers/staging/skein/skein_block.c | 31 +++++++++----------------------
>  1 file changed, 9 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
> index 66261ab..f89b410 100644
> --- a/drivers/staging/skein/skein_block.c
> +++ b/drivers/staging/skein/skein_block.c
> @@ -67,10 +67,8 @@ do {                                         \
>  } while (0)
>  
>  #if SKEIN_UNROLL_256 == 0
> -#define R256(p0, p1, p2, p3, ROT, r_num) /* fully unrolled */ \
> -do {                                                          \
> -	ROUND256(p0, p1, p2, p3, ROT, r_num);                 \
> -} while (0)
> +#define R256(p0, p1, p2, p3, ROT, r_num)	\
> +	ROUND256(p0, p1, p2, p3, ROT, r_num)
>  
>  #define I256(R)                                                           \
>  do {                                                                      \
> @@ -82,10 +80,7 @@ do {                                                                      \
>  } while (0)
>  #else
>  /* looping version */
> -#define R256(p0, p1, p2, p3, ROT, r_num) \
> -do { \
> -	ROUND256(p0, p1, p2, p3, ROT, r_num); \
> -} while (0)
> +#define R256(p0, p1, p2, p3, ROT, r_num) ROUND256(p0, p1, p2, p3, ROT, r_num)
>  
>  #define I256(R) \
>  do { \
> @@ -154,10 +149,8 @@ do {                                                         \
>  } while (0)
>  
>  #if SKEIN_UNROLL_512 == 0
> -#define R512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num) /* unrolled */ \
> -do {                                                                    \
> -	ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num);           \
> -} while (0)
> +#define R512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num)	\
> +	ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num)
>  
>  #define I512(R)                                                           \
>  do {                                                                      \
> @@ -173,10 +166,8 @@ do {                                                                      \
>  } while (0)
>  
>  #else /* looping version */
> -#define R512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num)                 \
> -do {                                                                     \
> -	ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num);            \
> -} while (0)
> +#define R512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num)		\
> +	ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num)
>  
>  #define I512(R)                                                           \
>  do {                                                                      \
> @@ -263,10 +254,8 @@ do {                                                                          \
>  #if SKEIN_UNROLL_1024 == 0
>  #define R1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, pF, \
>  	      ROT, rn)                                                        \
> -do {                                                                          \
>  	ROUND1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, \
> -		  pF, ROT, rn);                                               \
> -} while (0)
> +		  pF, ROT, rn)
>  
>  #define I1024(R)                                                          \
>  do {                                                                      \
> @@ -291,10 +280,8 @@ do {                                                                      \
>  #else /* looping version */
>  #define R1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, pF, \
>  	      ROT, rn)                                                        \
> -do {                                                                          \
>  	ROUND1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, \
> -		  pF, ROT, rn);                                               \
> -} while (0)
> +		  pF, ROT, rn)
>  
>  #define I1024(R)                                                           \
>  do {                                                                       \
> -- 
> 1.9.1

Doesn't apply to my tree :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/