linux-kernel - Re: [PATCH 2/2] futex: Fix argument handling in futex_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54BA2063.1020702@gmail.com>
Date:	Sat, 17 Jan 2015 09:42:11 +0100
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	Darren Hart <dvhart@...radead.org>
CC:	mtk.manpages@...il.com, Thomas Gleixner <tglx@...utronix.de>,
	lkml <linux-kernel@...r.kernel.org>,
	Darren Hart <darren@...art.com>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/2] futex: Fix argument handling in futex_lock_pi() calls

On 01/17/2015 03:04 AM, Darren Hart wrote:
> On Fri, Jan 16, 2015 at 08:28:06PM +0100, Michael Kerrisk (man-pages) wrote:
>> From: Michael Kerrisk <mtk.manpages@...il.com>
>>
>> This patch fixes two separate buglets in calls to futex_lock_pi():
>>
>>   * Eliminate unused 'detect' argument
>>   * Change unused 'timeout' argument of FUTEX_TRYLOCK_PI to NULL
> 
> One might argue these should be two separate fixes. Since both are trivial and functional
> no-ops, I'm going to ignore it and consider it a "cleanup" :-) Thomas may
> disagree.

Yup, and that's what I was going to do until I realized that the patches 
changed the same line. Then I thought it easier to combine them (rather 
than make dependent patches), since they're fairly trivial. But,
I'll split them if Thomas wishes.

Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/