linux-kernel - Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150117123834.GD18698@kernel.org>
Date:	Sat, 17 Jan 2015 09:38:34 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	David Ahern <dsahern@...il.com>, Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on
 TUI

Em Thu, Jan 15, 2015 at 09:20:21AM +0900, Namhyung Kim escreveu:
> On Wed, Jan 14, 2015 at 06:08:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jan 14, 2015 at 07:57:49AM -0700, David Ahern escreveu:
> > > On 1/14/15 4:18 AM, Namhyung Kim wrote:
> > > >  static inline struct annotation *symbol__annotation(struct symbol *sym)
> > > >  {
> > > >-	struct sannotation *a = container_of(sym, struct sannotation, symbol);
> > > >-	return &a->annotation;
> > > >+	return (void *)sym - symbol_conf.priv_size;
 
> > > symbol__priv(sym);

> > Amended, thanks.
 
> Oh, I missed that.  Thanks to both of you!

I thought I had, probably did, but in just one of my devel machines,
ended up going as Namhyung did, no biggie, I'll fix it up later, on the
next perf/core devel cycle.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/