linux-kernel - Re: [PATCH 2/2] ION handle already destroyed in ion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150118002200.GA8609@kroah.com>
Date:	Sat, 17 Jan 2015 16:22:00 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Shailendra Verma <shailendra.capricorn@...il.com>
Cc:	John Stultz <john.stultz@...aro.org>,
	Mitchel Humpherys <mitchelh@...eaurora.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ION handle already destroyed in ion_free.

On Sat, Jan 17, 2015 at 12:04:21PM +0530, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> ---
>  drivers/staging/android/ion/ion.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 9e56d32..0d2b9a3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> 		if (IS_ERR(handle))
> 			return PTR_ERR(handle);
> 		ion_free(client, handle);
> -		ion_handle_put(handle);
> 		break;
> 	}
> 	case ION_IOC_SHARE:
> --
> 1.7.9.5

Are you sure about this?  Did you test it?  How?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/