linux-kernel - Re: [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@...il.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54BBCFE2.9030801@gmail.com>
Date:	Sun, 18 Jan 2015 17:23:14 +0200
From:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
To:	Ahmadposten <ahmad.hassan612@...il.com>, devel@...verdev.osuosl.org
CC:	gclement@...bob.org, tvboxspy@...il.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	forest@...ttletooquiet.net, joe@...ches.com
Subject: Re: [PATCH] staging: vt6655: fix space prohibted before that ','
 Signed-off-by: Ahmadposten <ahmad.hassan612@...il.com>

On 2015.01.19 01:38, Ahmadposten wrote:
> ---
>  drivers/staging/vt6655/device_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index f5cc78e..34e3a76 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1090,7 +1090,7 @@ static  irqreturn_t  device_intr(int irq,  void *dev_instance)
>  	// Must do this after doing rx/tx, cause ISR bit is slow
>  	// than RD/TD write back
>  	// update ISR counter
> -	STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic , dwMIBCounter);
> +	STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic, dwMIBCounter);
>  	while (pDevice->dwIsr != 0) {
>  		STAvUpdateIsrStatCounter(&pDevice->scStatistic, pDevice->dwIsr);
>  		MACvWriteISR(pDevice->PortOffset, pDevice->dwIsr);
> 
Your subject is messed up. The Signed-off-by part should be in the
message before "---". Also, consider adding some text that describes
more precisely what you've changed. By the way, as a newbie you can
always send your patches to yourself before sending it off to a ML to
see if everything is okay.

-- 
Thanks,
Giedrius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/