linux-kernel - Re: [PATCH 1/5] clocksource: sun5i: Switch to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jan 2015 19:40:56 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/5] clocksource: sun5i: Switch to request_irq

On 01/11/2015 12:40 PM, Maxime Ripard wrote:
> The current code uses setup_irq, while it could perfectly use the much simpler
> request_irq. Switch to that.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>   drivers/clocksource/timer-sun5i.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
> index 02268448dc85..738853873a3b 100644
> --- a/drivers/clocksource/timer-sun5i.c
> +++ b/drivers/clocksource/timer-sun5i.c
> @@ -130,13 +130,6 @@ static irqreturn_t sun5i_timer_interrupt(int irq, void *dev_id)
>   	return IRQ_HANDLED;
>   }
>
> -static struct irqaction sun5i_timer_irq = {
> -	.name = "sun5i_timer0",
> -	.flags = IRQF_TIMER | IRQF_IRQPOLL,
> -	.handler = sun5i_timer_interrupt,
> -	.dev_id = &sun5i_clockevent,
> -};
> -
>   static u64 sun5i_timer_sched_read(void)
>   {
>   	return ~readl(timer_base + TIMER_CNTVAL_LO_REG(1));
> @@ -178,7 +171,8 @@ static void __init sun5i_timer_init(struct device_node *node)
>
>   	ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);
>
> -	ret = setup_irq(irq, &sun5i_timer_irq);
> +	ret = request_irq(irq, sun5i_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> +			  "sun5i_timer", &sun5i_clockevent);

Is the timer name change done in purpose ?

>   	if (ret)
>   		pr_warn("failed to setup irq %d\n", irq);
>
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/