| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150118190723.GH56582@vmdeb7> Date: Sun, 18 Jan 2015 11:07:23 -0800 From: Darren Hart <dvhart@...radead.org> To: Azael Avalos <coproscefalo@...il.com> Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/4] toshiba_acpi: Add support for USB Sleep functions On Wed, Jan 14, 2015 at 02:40:17PM -0700, Azael Avalos wrote: > The following patches add support to several USB Sleep functions > found on newer Toshiba laptops, allowing to use th USB ports while > the laptop is asleep or turned off. > > Azael Avalos (4): > toshiba_acpi: Add support for USB Sleep and Charge function > toshiba_acpi: Add support for USB Sleep functions under battery > toshiba_acpi: Add support for USB Rapid Charge > toshiba_acpi: Add support for USB Sleep and Music > > drivers/platform/x86/toshiba_acpi.c | 449 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 449 insertions(+) Hi Azael, Ignore my comments on input validation and error codes, you cover the former, and the latter keeps the driver internally consistent. That only leaves the Disable/Auto/Alternate values and a couple trivial formatting and typos to address. Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists