lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Jan 2015 22:00:36 +0100 From: Pavel Machek <pavel@....cz> To: Colin King <colin.king@...onical.com> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] PM / clock_ops: initialize ret to avoid garbage being returned On Thu 2015-01-08 15:31:01, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > cppcheck detected an unitialised ret: > [drivers/base/power/clock_ops.c:53]: (error) Uninitialized variable: ret > > ret is only assigned if ce->status < PCE_STATUS_ERROR, if this is false > then __pm_clk_enable returns whatever garbage ret picks up from the stack. > > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/base/power/clock_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > index d626576..5bd283d 100644 > --- a/drivers/base/power/clock_ops.c > +++ b/drivers/base/power/clock_ops.c > @@ -39,7 +39,7 @@ struct pm_clock_entry { > */ > static inline int __pm_clk_enable(struct device *dev, struct pm_clock_entry *ce) > { > - int ret; > + int ret = 0; > > if (ce->status < PCE_STATUS_ERROR) { > ret = clk_enable(ce->clk); Actually, is this right solution? If clock entry has an error, we won't enable it, and should probably return some kind of error...? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists