linux-kernel - Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150118030748.GA31575@kroah.com>
Date:	Sat, 17 Jan 2015 19:07:48 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Andrew Milkovich <amilkovich@...il.com>
Cc:	benjamin.romer@...sys.com, david.kershner@...sys.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote:
> Hi,
> 
> On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote:
> > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote:
> > > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
> > > comment is implied by the first argument being the channel. No parent bus
> > > comment is already understood by the argument being NULL.
> > > 
> > > Signed-off-by: Andrew Milkovich <amilkovich@...il.com>
> > > ---
> > >  drivers/staging/unisys/virtpci/virtpci.c | 24 ++++++++----------------
> > >  1 file changed, 8 insertions(+), 16 deletions(-)
> > 
> > This doesn't apply to my staging-testing branch at all, sorry.
> > 
> > greg k-h
> 
> Processing the patch with 'git apply' complains about a corruption; this is due
> to the fact that I ran cleanfile on the patch. The checkpatch.pl script was
> giving errors about trailing whitespace. I ran cleanpatch, errors still showed
> up, I ran cleanfile and it passed.
> 
> Using 'patch -p1 < patchname' seems to work.

Doesn't work for me, try it against the branch above, I think it was due
to other changes in this driver in my tree.

If not, just resend, maybe I messed something up on my end, it has been
known to happen :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/