linux-kernel - Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150118082921.GB1150@shodan.fritz.box>
Date:	Sun, 18 Jan 2015 09:29:21 +0100
From:	Robin Schroer <sulamiification@...il.com>
To:	Shirish Gajera <gajerashirish@...il.com>
Cc:	w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
	samuel.thibault@...-lyon.org, gregkh@...uxfoundation.org,
	domagoj.trsan@...il.com, dan.carpenter@...cle.com,
	roxanagabriela10@...il.com, dilekuzulmez@...il.com,
	ben@...adent.org.uk, daeseok.youn@...il.com,
	aysemelikeyurtoglu@...il.com, rusty@...tcorp.com.au,
	tapaswenipathak@...il.com, sasha.levin@...cle.com,
	speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index e9f0c15..141abb7 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -422,8 +422,10 @@ static void announce_edge(struct vc_data *vc, int msg_id)
>  {
>  	if (spk_bleeps & 1)
>  		bleep(spk_y);
> -	if ((spk_bleeps & 2) && (msg_id < edge_quiet))
> -		synth_printf("%s\n", spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> +	if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> +		synth_printf("%s\n",
> +		spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> +	}
>  }
>  
You do not actually need to add the braces as this remains a single
statement (mnemonic: without braces the if ends at the first semicolon).

-- 

Robin Schroer

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/