linux-kernel - Re: [PATCH] fujitsu-laptop: use FB_BLANK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150118095443.GB16157@marvin.atrad.com.au>
Date:	Sun, 18 Jan 2015 20:24:44 +1030
From:	Jonathan Woithe <jwoithe@...t42.net>
To:	Michael Karcher <kernel@...rcher.dialup.fu-berlin.de>
Cc:	Darren Hart <dvhart@...radead.org>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michael Karcher <karcher@...sik.fu-berlin.de>
Subject: Re: [PATCH] fujitsu-laptop: use FB_BLANK_* constants

On Sun, Jan 18, 2015 at 01:02:11AM +0100, Michael Karcher wrote:
> From: Michael Karcher <karcher@...sik.fu-berlin.de>

This looks ok to me.

Acked-by: Jonathan Woithe <jwoithe@...t42.net>

> Signed-off-by: Michael Karcher <kernel@...rcher.dialup.fu-berlin.de>
> ---
>  drivers/platform/x86/fujitsu-laptop.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 7c21c1c..2a9afa2 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -64,6 +64,7 @@
>  #include <linux/acpi.h>
>  #include <linux/dmi.h>
>  #include <linux/backlight.h>
> +#include <linux/fb.h>
>  #include <linux/input.h>
>  #include <linux/kfifo.h>
>  #include <linux/platform_device.h>
> @@ -398,7 +399,7 @@ static int bl_get_brightness(struct backlight_device *b)
>  static int bl_update_status(struct backlight_device *b)
>  {
>  	int ret;
> -	if (b->props.power == 4)
> +	if (b->props.power == FB_BLANK_POWERDOWN)
>  		ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3);
>  	else
>  		ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0);
> @@ -1139,9 +1140,9 @@ static int __init fujitsu_init(void)
>  
>  	if (!acpi_video_backlight_support()) {
>  		if (call_fext_func(FUNC_BACKLIGHT, 0x2, 0x4, 0x0) == 3)
> -			fujitsu->bl_device->props.power = 4;
> +			fujitsu->bl_device->props.power = FB_BLANK_POWERDOWN;
>  		else
> -			fujitsu->bl_device->props.power = 0;
> +			fujitsu->bl_device->props.power = FB_BLANK_UNBLANK;
>  	}
>  
>  	pr_info("driver " FUJITSU_DRIVER_VERSION " successfully loaded\n");
> -- 
> 2.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/