linux-kernel - Re: [PATCH v4 0/4] power: Add max77693 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1421653226.4247.5.camel@AMDC1943>
Date:	Mon, 19 Jan 2015 08:40:26 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH v4 0/4] power: Add max77693 charger driver

On nie, 2015-01-18 at 18:00 +0000, Lee Jones wrote:
> Tell us what you need?

Hi Lee,


All I need is... acks or applying of patchset by Sebastian. Sebastian
acked main patch (3/4) but then I changed it [1].

You already acked the MFD change (patch 2/4: mfd: max77693: Add defines
for MAX77693 charger driver).

The patch with bindings (1/4: devicetree: power/mfd: max77693: Document
new bindings for charger) actually adds bindings for charger so rather
Sebastian's opinion is needed.

Other patches are from power supply subsystem.
Thanks for asking!


Dear Sebastian,

You already looked at the patchset [1], so maybe you could pick it up?

[1] https://lkml.org/lkml/2014/10/27/774

Best regards,
Krzysztof

> 
> > Changes since v3
> > ================
> > 1. Patch 3/4: Don't create platform data structure for charger settings
> >    because driver won't be used on non-DT SoCs (its for Exynos based
> >    Trats2).
> > 2. Patch 3/4: Drop Sebastian's ack [1] because of change above.
> > 
> > Changes since v2
> > ================
> > 1. Add ack from Sebastian Reichel (charger driver).
> > 2. Drop patch "mfd: max77693: Map charger device to its own of_node"
> >    (applied by Lee Jones).
> > 
> > 
> > Changes since v1
> > ================
> > 1. Add patch 2/5: mfd: max77693: Map charger device to its own of_node
> >    (forgot to send it in v1)
> > 2. Remove patches for DTS and configs. I'll send them later.
> > 3. Add ack from Lee Jones (patch 3/5).
> > 
> > 
> > Description
> > ===========
> > The patchset adds max77693 charger driver present on Trats2 board
> > (and Galaxy S III). The driver configures battery charger and exposes
> > power supply interface.
> > 
> > Driver is necessary to provide full charging stack on Trats2 device
> > (extcon, charger-manager etc.).
> > 
> > [1] https://lkml.org/lkml/2014/10/27/774
> > 
> > 
> > Best regards,
> > Krzysztof
> > 
> > 
> > 
> > Krzysztof Kozlowski (4):
> >   devicetree: power/mfd: max77693: Document new bindings for charger
> >   mfd: max77693: Add defines for MAX77693 charger driver
> >   power: max77693: Add charger driver for Maxim 77693
> >   Documentation: power: max77693-charger: Document exported sysfs entry
> > 
> >  Documentation/ABI/testing/sysfs-class-power        |  42 ++
> >  Documentation/devicetree/bindings/mfd/max77693.txt |  45 ++
> >  drivers/power/Kconfig                              |   6 +
> >  drivers/power/Makefile                             |   1 +
> >  drivers/power/max77693_charger.c                   | 758 +++++++++++++++++++++
> >  include/linux/mfd/max77693-private.h               | 108 +++
> >  6 files changed, 960 insertions(+)
> >  create mode 100644 drivers/power/max77693_charger.c
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/