linux-kernel - Re: [PATCH v10 0/6] Add Skyworks SKY81452 device drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150119081020.GC21886@x1>
Date:	Mon, 19 Jan 2015 08:10:20 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Gyungoh Yoo <gyungoh@...il.com>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	sameo@...ux.intel.com, grant.likely@...aro.org,
	jg1.han@...sung.com, cooloney@...il.com, trivial@...nel.org,
	akpm@...ux-foundation.org, jic23@...nel.org,
	thomas.petazzoni@...e-electrons.com, ktsai@...ellamicro.com,
	hs@...x.de, stwiss.opensource@...semi.com, matti.vaittinen@....com,
	broonie@...nel.org, jason@...edaemon.net, heiko@...ech.de,
	shawn.guo@...escale.com, florian.vaussard@...l.ch, andrew@...n.ch,
	antonynpavlov@...il.com, hytszk@...il.com, plagnioj@...osoft.com,
	tomi.valkeinen@...com, jack.yoo@...worksinc.com,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v10 0/6] Add Skyworks SKY81452 device drivers

On Mon, 19 Jan 2015, Gyungoh Yoo wrote:

> On Sun, Jan 18, 2015 at 05:40:37PM +0000, Lee Jones wrote:
> > > From: Gyungoh Yoo <jack.yoo@...worksinc.com>
> > > 
> > > This patch set includes regulator and backlight driver for SKY81452.
> > > Also it includes documents for device tree and module.
> > > sky81452-regulator was already applied. So this series doesn't
> > > include it.
> > 
> > Tell us what you need?  What's missing?
> 
> I need DT's Ack for 3/6 and 4/6.

Patch 3 looks simple enough.

Patch 4 _does_ need a DT ack though.

> > > v10:
> > > Removed trivial get_brightness implementations for sky81452-backlight
> > > 
> > > v9:
> > > Removed the change to remove MODULE_VERSION() for sky81452-regulator
> > > 
> > > v8:
> > > Renamed property names for backlight with vendor prefix
> > > Modified gpio-enable property to generic property for GPIO
> > > Made up the example for backlight DT
> > > Changed the DT parsing of regulator using regulator_node and of_match
> > > 
> > > v7:
> > > Modified licensing text to GPLv2
> > > Splitted Kconfig renaming from DT patch
> > > 
> > > v6:
> > > Added new line character at the end of line of dev_err()
> > > 
> > > v5:
> > > Changed DT for regulator : 'lout' node should be defined under 'regulator'
> > > Removed compatible string from sky81452-regulator driver
> > > Modified sky81452-regulator to return EINVAL when of_node is NULL
> > > Move sky81452-backlight.h to include/linux/platform_data
> > > 
> > > v4:
> > > Removed MODULE_VERSION()
> > > Modified license to GPLv2
> > > Removed calling to backlight_device_unregister() in sky81452-backlight
> > > 
> > > v3:
> > > Cleaned-up DBG messages
> > > Cleaned-up DT
> > > Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight'
> > > Assigned mfd_cell.of_compatible for binding device node
> > > Modified error messages
> > > Modified sky81452-regulator to return ENODATA when of_node is NULL
> > > 
> > > v2:
> > > Split the patches for each sub-system
> > > Added 'reg' attribute for I2C address in device tree documents
> > > Added 'compatible' attribute in child drivers
> > > Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452
> > > Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452
> > > Added message for exception or errors.
> > > Added vendor prefix for Skyworks Solutions, Inc.
> > > Add SKY81452 to the Trivial Devices list
> > > 
> > > Gyungoh Yoo (6):
> > >   mfd: Add support for Skyworks SKY81452 driver
> > >   backlight: Add support Skyworks SKY81452 backlight driver
> > >   devicetree: mfd: Add new SKY81452 mfd binding
> > >   devicetree: backlight: Add new SKY81452 backlight binding
> > >   devicetree: Add vendor prefix for Skyworks Solutions, Inc.
> > >   devicetree: i2c: Add SKY81452 to the Trivial Devices list
> > > 
> > >  .../devicetree/bindings/i2c/trivial-devices.txt    |   1 +
> > >  Documentation/devicetree/bindings/mfd/sky81452.txt |  36 +++
> > >  .../devicetree/bindings/vendor-prefixes.txt        |   1 +
> > >  .../video/backlight/sky81452-backlight.txt         |  29 ++
> > >  drivers/mfd/Kconfig                                |  12 +
> > >  drivers/mfd/Makefile                               |   1 +
> > >  drivers/mfd/sky81452.c                             | 108 +++++++
> > >  drivers/video/backlight/Kconfig                    |  10 +
> > >  drivers/video/backlight/Makefile                   |   1 +
> > >  drivers/video/backlight/sky81452-backlight.c       | 334 +++++++++++++++++++++
> > >  include/linux/mfd/sky81452.h                       |  31 ++
> > >  include/linux/platform_data/sky81452-backlight.h   |  46 +++
> > >  12 files changed, 610 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt
> > >  create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > >  create mode 100644 drivers/mfd/sky81452.c
> > >  create mode 100644 drivers/video/backlight/sky81452-backlight.c
> > >  create mode 100644 include/linux/mfd/sky81452.h
> > >  create mode 100644 include/linux/platform_data/sky81452-backlight.h
> > > 
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/