linux-kernel - Re: [PATCH] drivers/usb/serial/mos7840.c: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150119102844.GN30960@localhost>
Date:	Mon, 19 Jan 2015 11:28:44 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/serial/mos7840.c: remove unused code

On Tue, Jan 13, 2015 at 05:41:45PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is old, unused code that is #defined out by the
> use of NOTMOS7840 - this is not defined anywhere.  If
> NOTMOS7840 is defined then the code will break on null
> pointer dereferences on mos7840_port.  So the code is
> currently unused, and broken anyway, so why not just
> remove it.

Makes sense. But why not remove the likewise broken code conditionally
compiled on NOTMCS7840 as well?

Care to resend and include that as well?

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/