linux-kernel - RE: [PATCH v18 04/12] input: cyapa: add runtime power management interfaces support for the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN1PR06MB07098EF08CBC9493CC132CDD14A0@BN1PR06MB070.namprd06.prod.outlook.com>
Date:	Mon, 19 Jan 2015 01:52:20 +0000
From:	Dudley Du <dudl@...ress.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"jmmahler@...il.com" <jmmahler@...il.com>,
	"rydberg@...omail.se" <rydberg@...omail.se>,
	"bleung@...gle.com" <bleung@...gle.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v18 04/12] input: cyapa: add runtime power management
 interfaces support for the device



> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@...il.com]
> Sent: 2015?1?18? 16:32
> To: Dudley Du
> Cc: jmmahler@...il.com; rydberg@...omail.se; bleung@...gle.com;
> linux-input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v18 04/12] input: cyapa: add runtime power management
> interfaces support for the device
>
> Hi Dudley,
>
> On Fri, Jan 16, 2015 at 02:34:07PM +0800, Dudley Du wrote:
>
> > +#ifdef CONFIG_PM_RUNTIME
> > +static ssize_t cyapa_show_rt_suspend_scanrate(struct device *dev,
> > +      struct device_attribute *attr,
> > +      char *buf)
>
> The runtime PM was switched to just CONFIG_PM in mainline and
> CONFIG_PM_RUNTIME was dropped. I adjusted the patch accordingly.

Thanks, I will update my knowledge.;)

>
> ...
>
> > -static SIMPLE_DEV_PM_OPS(cyapa_pm_ops, cyapa_suspend, cyapa_resume);
> > +#ifdef CONFIG_PM_RUNTIME
> > +static int cyapa_runtime_suspend(struct device *dev)
>
> I switched both cyapa_runtme_suspend and resume to __maybe_unused and
> dropped #ifdef guards.
>
> Thanks.
>
> --
> Dmitry

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/