linux-kernel - Re: [PATCH] arch: arm: mach-ux500: board-mop500-regulators.c: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11128609.Upt8IQGP29@wuerfel>
Date:	Mon, 19 Jan 2015 11:00:57 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Linus Walleij <linus.walleij@...aro.org>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: arm: mach-ux500: board-mop500-regulators.c: Remove unused function

On Sunday 18 January 2015 18:07:47 Lee Jones wrote:
> On Fri, 02 Jan 2015, Arnd Bergmann wrote:
> 
> > On Thursday 01 January 2015 16:40:05 Rickard Strandqvist wrote:
> > > Remove the function mop500_regulator_init() that is not used anywhere.
> > > 
> > > This was partially found by using a static code analysis program called cppcheck.
> > > 
> > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> > 
> > This looks wrong: For one thing, you failed to notice that now another function
> > in the same file becomes unused, or that half of the file is not used
> > anyway.
> > 
> > It also seems that the fact that this function is not called was an accident
> > and it should in fact be called. Maybe Lee has some more insight in this,
> > as he added the function in the first place.
> > 
> > Finally (unrelated to your patch, but triggered by looking at it), I suspect
> > we should just move the ab8500_regulator_plat_data and everything it references
> > to drivers/regulator/ab8500-ext.c, because we only have one instance of it
> > and won't ever have more.
> 
> This is old code.  The development of this stuff was halted before it
> could be finished.  Feel free to remove it and all other unused code
> it uncovers.
> 

Thanks for the confirmation!

Richard, do you feel up to doing the task of the broader cleanup here?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/