linux-kernel - Re: [PATCH 23/28] PCI/designware: Use pci_scan_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54BC775B.5020400@huawei.com>
Date:	Mon, 19 Jan 2015 11:17:47 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Liviu Dudau <liviu@...au.co.uk>, Tony Luck <tony.luck@...el.com>,
	"Russell King" <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Marc Zyngier <marc.zyngier@....com>,
	<linux-pci@...r.kernel.org>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	<linux-m68k@...ts.linux-m68k.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	<linux-alpha@...r.kernel.org>, <linux-ia64@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Yinghai Lu <yinghai@...nel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity

On 2015/1/18 0:39, Sergei Shtylyov wrote:
> Hello.
> 
> On 1/16/2015 4:44 AM, Yijing Wang wrote:
> 
>> Use pci_scan_root_bus() instead of pci_create_root_bus() +
>> pci_scan_child_bus() for simplicity.
> 
>> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
>> ---
>>   drivers/pci/host/pcie-designware.c |    4 +---
>>   1 files changed, 1 insertions(+), 3 deletions(-)
> 
>> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
>> index eef3111..d37fe27 100644
>> --- a/drivers/pci/host/pcie-designware.c
>> +++ b/drivers/pci/host/pcie-designware.c
>> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
>>       struct pcie_port *pp = sys_to_pcie(sys);
>>
>>       pp->root_bus_nr = sys->busnr;
>> -    bus = pci_create_root_bus(pp->dev, sys->busnr,
>> +    bus = pci_scan_root_bus(pp->dev, sys->busnr,
>>                     &dw_pcie_ops, sys, &sys->resources);
> 
>    Please realign this line, so that it still starts under 'pp'.

ok.

> 
> WBR, Sergei
> 
> 
> .
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/