linux-kernel - Re: [PATCH v2 1/3] Drivers: hv: check vmbus_device_create() return value in vmbus_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150119180301.GF6456@mwanda>
Date:	Mon, 19 Jan 2015 21:03:01 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:	Radim Krčmář <rkrcmar@...hat.com>,
	Jason Wang <jasowang@...hat.com>, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH v2 1/3] Drivers: hv: check vmbus_device_create() return
 value in vmbus_process_offer()

On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote:
> "error" is a crap label name because it doesn't tell you what the code
> does.  A better name is "err_free_chan" or something which talks about
> freeing the channel.

If you choose your label names correctly, then most of the time you can
just read the code from top to bottom and understand it without skipping
back and forth.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/