linux-kernel - Re: [PATCH v2] irqchip: omap-intc: fix legacy DMA regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150119183409.GZ18552@atomide.com>
Date:	Mon, 19 Jan 2015 10:34:09 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Jason Cooper <jason@...edaemon.net>
Cc:	Felipe Balbi <balbi@...com>, Thomas Gleixner <tglx@...utronix.de>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Kümmel <syntheticpp@....net>,
	Pavel Machek <pavel@....cz>,
	Santosh Shilimkar <ssantosh@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH v2] irqchip: omap-intc: fix legacy DMA regression

* Jason Cooper <jason@...edaemon.net> [150106 19:03]:
> On Tue, Jan 06, 2015 at 02:38:08PM -0600, Felipe Balbi wrote:
> > commit 55601c9f2467 (arm: omap: intc: switch over
> > to linear irq domain) introduced a regression with
> > SDMA legacy driver because that driver strictly depends
> > on INTC's IRQs starting at NR_IRQs. Aparently
> > irq_domain_add_linear() won't guarantee that, since we see
> > a 7 IRQs difference when booting with and without the
> > commit cited above.
> > 
> > Until arch/arm/plat-omap/dma.c is properly fixed, we
> > must maintain OMAP2/3 using irq_domain_add_legacy().
> > 
> > A FIXME note was added so people know to delete that
> > code once that legacy DMA driver is fixed up.
> > 
> > Fixes: 55601c9f2467 (arm: omap: intc: switch over to linear irq domain)
> > Cc: <stable@...r.kernel.org> # v3.18
> > Tested-by: Aaro Koskinen <aaro.koskinen@....fi>
> > Tested-by: Tony Lindgren <tony@...mide.com>
> > Signed-off-by: Felipe Balbi <balbi@...com>
> > ---
> >  drivers/irqchip/irq-omap-intc.c | 26 +++++++++++++++++++++-----
> >  1 file changed, 21 insertions(+), 5 deletions(-)
> 
> Applied to irqchip/urgent.  Thanks for taking care of the Fixes and
> stable tags!

Jason, I'm not seeing this merged into v3.19-rc5, seems to be
in Linux next though.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/