linux-kernel - Re: [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct clk instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54BD4F84.1010501@codeaurora.org>
Date:	Mon, 19 Jan 2015 10:40:04 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Paul Walmsley <paul@...an.com>,
	Tony Lindgren <tony@...mide.com>,
	Russell King <linux@....linux.org.uk>,
	linux-omap@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH RESEND v8 1/2] clk: Make clk API return per-user struct
 clk instances

On 01/19/2015 01:55 AM, Tomeu Vizoso wrote:
> On 17 January 2015 at 02:02, Stephen Boyd <sboyd@...eaurora.org> wrote:
>> On 01/12, Tomeu Vizoso wrote:
>>
>>> +}
>>>  EXPORT_SYMBOL_GPL(__clk_get_rate);
>>>
>>> @@ -630,7 +656,12 @@ out:
>>>       return !!ret;
>>>  }
>>>
>>> -bool __clk_is_enabled(struct clk *clk)
>>> +bool __clk_is_prepared(struct clk *clk)
>>> +{
>>> +     return clk_core_is_prepared(clk->core);
>> Oops. clk can be NULL here. Return false if so. Or drop the
>> function entirely? It looks like it may become unused.
> Are you thinking of anything specific that the alchemy arch can do
> instead of calling __clk_is_prepared?
>
>

Ah I missed that one. Bad grep.

>>> +}
>>>  EXPORT_SYMBOL_GPL(__clk_is_enabled);
>>>
>>> @@ -762,7 +805,12 @@ void __clk_unprepare(struct clk *clk)
>>>       if (clk->ops->unprepare)
>>>               clk->ops->unprepare(clk->hw);
>>>
>>> -     __clk_unprepare(clk->parent);
>>> +     clk_core_unprepare(clk->parent);
>>> +}
>>> +
>>> +void __clk_unprepare(struct clk *clk)
>>> +{
>>> +     clk_core_unprepare(clk->core);
>> OOps. clk can be NULL here. Bail early if so.
> Actually, looks like nobody is using __clk_prepare nor __clk_unprepare
> so I'm removing these.
>

Ok.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/