linux-kernel - Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150119185519.GK9759@ld-irv-0074>
Date:	Mon, 19 Jan 2015 10:55:19 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Ursula Braun <ursula.braun@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Frank Blaschka <blaschka@...ux.vnet.ibm.com>,
	linux390@...ibm.com, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two
 function calls

I went digging through some of Markus's old patch history, and noticed
this...

On Mon, Nov 03, 2014 at 12:50:59PM +0300, Dan Carpenter wrote:
> This one is buggy.
> 
> I'm sorry, but please stop sending these.

I'm tending to concur.

> For kfree(), at least we all know that kfree() accepts NULL pointer.
> But for this one:
> 1) I don't know what the functions do so I have to look at the code.
> 2) It's in a arch that I don't compile so cscope isn't set up meaning
>    it's hard to find the functions.
> 
> You're sending a lot of patches and they are all hard to review and some
> of them are buggy and none of them really add any value.  It's a waste
> of your time and it's a waste of my time.

And you're still sending buggy patches that exhibit the same qualities.
They're still wasting Dan's time, and now they're wasting mine.

I appreciate automated checkers where they provide added value, but I
really feel you haven't done your diligence on them.

Regards,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/