linux-kernel - Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150119202638.GC6507@mwanda>
Date:	Mon, 19 Jan 2015 23:26:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	shirish gajera <gajerashirish@...il.com>
Cc:	Ben Hutchings <ben@...adent.org.uk>, kirk@...sers.ca,
	Rusty Russell <rusty@...tcorp.com.au>,
	Greg KH <gregkh@...uxfoundation.org>,
	DaeSeok Youn <daeseok.youn@...il.com>,
	Robin Schroer <sulamiification@...il.com>,
	speakup@...ux-speakup.org,
	Ayşe Melike Yurtoğlu 
	<aysemelikeyurtoglu@...il.com>, linux-kernel@...r.kernel.org,
	Domagoj Tršan <domagoj.trsan@...il.com>,
	Roxana Blaj <roxanagabriela10@...il.com>,
	tapaswenipathak@...il.com,
	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Dilek Üzülmez <dilekuzulmez@...il.com>,
	sasha.levin@...cle.com,
	Christopher Brannon <chris@...-brannons.com>
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Mon, Jan 19, 2015 at 12:00:34PM -0800, shirish gajera wrote:
> I am confuse whether to wait till the patch got accepted or submit new
> patch set.

Just wait for Greg to get to the patch.  We pretty much always apply
long line fixes so just assume it's going to merged.

> 
> Also, how to identify whether the corresponding warning is real or not ?

It's all a matter of personal taste.  The end code should look better
than the original code.  I thought your changes looked pretty good...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/