linux-kernel - Re: [RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific mount function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150119211050.GG29656@ZenIV.linux.org.uk>
Date:	Mon, 19 Jan 2015 21:10:50 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific
 mount function.

On Mon, Jan 19, 2015 at 09:47:20PM +0100, Fabian Frederick wrote:
> Currently, a lot of filesystem mounting functions feature in
> file_system_type only to be called from vfs mount_fs and call mount_bdev.
> 
> This patch adds fill_super function to that structure and lets vfs
> call mount_bdev when no mount function is declared.

NAK.  First of all, quite a few of them are _not_ mount_bdev() users.
What's more, you are trading about 4 lines per filesystem (two of them
being { and }) for a layering violation.

No point whatsoever.  fill_super() is no more a method than e.g. get_block().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/