linux-kernel - Re: [Patch RESEND] x86: don't rely on VMWare emulating PAT MSR correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54BC9095.9080506@suse.com>
Date:	Mon, 19 Jan 2015 06:05:25 +0100
From:	Juergen Gross <jgross@...e.com>
To:	hpa@...or.com, x86@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, linux-kernel@...r.kernel.org
CC:	akataria@...are.com, jongman.heo@...sung.com
Subject: Re: [Patch RESEND] x86: don't rely on VMWare emulating PAT MSR correctly

PING!

The patch repairs a bug with VMWARE, which has been reported by several
users. All of them have confirmed the patch is working. And VMWARE has
acked the patch. What else do you need to take it? It is available for
over a month now!

Juergen

On 01/12/2015 06:15 AM, Juergen Gross wrote:
> VMWare seems not to emulate the PAT MSR correctly: reaeding
> MSR_IA32_CR_PAT returns 0 even after writing another value to it.
>
> Detect this bug and don't use the read value if it is 0.
>
> Commit bd809af16e3ab1f8d55b3e2928c47c67e2a865d2 ("x86: Enable PAT to
> use cache mode translation tables") triggers this VMWare bug when the
> kernel is booted as a VMWare guest.
>
> Reported-by: Jongman Heo <jongman.heo@...sung.com>
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Tested-by: Jongman Heo <jongman.heo@...sung.com>
> Acked-by: Alok N Kataria <akataria@...are.com>
> ---
>   arch/x86/mm/pat.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index edf299c..7ac6869 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -234,8 +234,13 @@ void pat_init(void)
>   	      PAT(4, WB) | PAT(5, WC) | PAT(6, UC_MINUS) | PAT(7, UC);
>
>   	/* Boot CPU check */
> -	if (!boot_pat_state)
> +	if (!boot_pat_state) {
>   		rdmsrl(MSR_IA32_CR_PAT, boot_pat_state);
> +		if (!boot_pat_state) {
> +			pat_disable("PAT read returns always zero, disabled.");
> +			return;
> +		}
> +	}
>
>   	wrmsrl(MSR_IA32_CR_PAT, pat);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/