linux-kernel - Re: [PATCH] staging: iio: tsl2583: fix format string warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2015 20:43:29 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Asaf Vertz <asaf.vertz@...demg.com>, gregkh@...uxfoundation.org
CC:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	mwelling@...e.org, daniel.baluta@...el.com, aybuke.147@...il.com,
	monamagarwal123@...il.com, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: tsl2583: fix format string warnings

On 20/01/15 10:43, Asaf Vertz wrote:
> Fixed the following warnings (reported by cppcheck):
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 2)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 3)
> requires 'int' but the argument type is 'unsigned int'.
> 
> Signed-off-by: Asaf Vertz <asaf.vertz@...demg.com>
Applied to the togreg branch of iio.git - initially pushed out
as testing.  Note this branch will almost certainly get rebased
before going upstream.

Jonathan
> ---
>  drivers/staging/iio/light/tsl2583.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index cc4ddcc..8afae8e 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -692,7 +692,7 @@ static ssize_t taos_luxtable_show(struct device *dev,
>  	int offset = 0;
>  
>  	for (i = 0; i < ARRAY_SIZE(taos_device_lux); i++) {
> -		offset += sprintf(buf + offset, "%d,%d,%d,",
> +		offset += sprintf(buf + offset, "%u,%u,%u,",
>  				  taos_device_lux[i].ratio,
>  				  taos_device_lux[i].ch0,
>  				  taos_device_lux[i].ch1);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/