linux-kernel - Re: [PATCH] staging: iio: ad5933: fix format string warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54BEBE72.5020106@kernel.org>
Date:	Tue, 20 Jan 2015 20:45:38 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Asaf Vertz <asaf.vertz@...demg.com>, gregkh@...uxfoundation.org
CC:	Michael.Hennerich@...log.com, knaack.h@....de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: ad5933: fix format string warnings

On 20/01/15 08:52, Lars-Peter Clausen wrote:
> On 01/20/2015 08:25 AM, Asaf Vertz wrote:
>> Fixed the following warnings (reported by cppcheck):
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4)
>> requires 'int' but the argument type is 'unsigned int'.
>>
>> Signed-off-by: Asaf Vertz <asaf.vertz@...demg.com>
> 
> Acked-by: Lars-Peter Clausen <lars@...afoo.de>
Applied to the togreg branch of iio.git. Initially pushed out
as testing.  Thanks,

Jonathan
> 
> Thanks.
> 
>> ---
>>   drivers/staging/iio/impedance-analyzer/ad5933.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
>> index b6bd609..4230a43 100644
>> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
>> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
>> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
>>       mutex_lock(&indio_dev->mlock);
>>       switch ((u32) this_attr->address) {
>>       case AD5933_OUT_RANGE:
>> -        len = sprintf(buf, "%d\n",
>> +        len = sprintf(buf, "%u\n",
>>                     st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
>>           break;
>>       case AD5933_OUT_RANGE_AVAIL:
>> -        len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
>> +        len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
>>                     st->range_avail[3], st->range_avail[2],
>>                     st->range_avail[1]);
>>           break;
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/