linux-kernel - Re: [RFC] block: Remove annoying "unknown partition table" message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54BECD89.7030404@fb.com>
Date:	Tue, 20 Jan 2015 14:50:01 -0700
From:	Jens Axboe <axboe@...com>
To:	Boaz Harrosh <boaz@...xistor.com>,
	Christoph Hellwig <hch@...radead.org>
CC:	Tony Luck <tony.luck@...il.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Dmitry Monakhov <dmonakhov@...nvz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [RFC] block: Remove annoying "unknown partition table" message

On 01/18/2015 08:48 AM, Boaz Harrosh wrote:
> On 01/18/2015 05:32 PM, Boaz Harrosh wrote:
>> From: Boaz Harrosh <boaz@...xistor.com>
>>
>> As Christoph put it best:
>>   Can we just get rid of the warnings?  It's fairly annoying as devices
>>   without partitions are perfectly fine and very useful.
>>
>> Me too I see this message every VM boot for ages on all my
>> devices. Would love to just remove it. For me a partition-table
>> is only needed for a booting BIOS, grub, and stuff.
>>
>> (NOT Yet Tested)
>>
>> CC: Christoph Hellwig <hch@...radead.org>
>> Signed-off-by: Boaz Harrosh <boaz@...xistor.com>
>> ---
>>  block/partitions/check.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/block/partitions/check.c b/block/partitions/check.c
>> index 9ac1df7..e3a9077 100644
>> --- a/block/partitions/check.c
>> +++ b/block/partitions/check.c
>> @@ -184,9 +184,7 @@ check_partition(struct gendisk *hd, struct block_device *bdev)
>>  	if (err)
>>  	/* The partition is unrecognized. So report I/O errors if there were any */
>>  		res = err;
>> -	if (!res)
>> -		strlcat(state->pp_buf, " unknown partition table\n", PAGE_SIZE);
>> -	else if (warn_no_part)
>> +	if (warn_no_part)
>>  		strlcat(state->pp_buf, " unable to read partition table\n", PAGE_SIZE);
>>  
>>  	printk(KERN_INFO "%s", state->pp_buf);
>>
> 
> Off course that was untested crap something like:
> ---
> diff --git a/block/partitions/check.c b/block/partitions/check.c
> index 9ac1df7..16118d1 100644
> --- a/block/partitions/check.c
> +++ b/block/partitions/check.c
> @@ -184,12 +184,12 @@ check_partition(struct gendisk *hd, struct block_device *bdev)
>  	if (err)
>  	/* The partition is unrecognized. So report I/O errors if there were any */
>  		res = err;
> -	if (!res)
> -		strlcat(state->pp_buf, " unknown partition table\n", PAGE_SIZE);
> -	else if (warn_no_part)
> -		strlcat(state->pp_buf, " unable to read partition table\n", PAGE_SIZE);
> -
> -	printk(KERN_INFO "%s", state->pp_buf);
> +	if (res) {
> +		if (warn_no_part)
> +			strlcat(state->pp_buf,
> +				" unable to read partition table\n", PAGE_SIZE);
> +		printk(KERN_INFO "%s", state->pp_buf);
> +	}
>  
>  	free_page((unsigned long)state->pp_buf);
>  	free_partitions(state);
> ---
> Not-Signed-off-yet: Boaz Harrosh <boaz@...xistor.com>

Were you going to send a tested patch with the commit message?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/