linux-kernel - Re: linux-next: Tree for Jan 20 -- Kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120225041.GK29656@ZenIV.linux.org.uk>
Date:	Tue, 20 Jan 2015 22:50:41 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Sabrina Dubroca <sd@...asysnail.net>,
	Paul Moore <pmoore@...hat.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-audit@...hat.com,
	Richard Guy Briggs <rgb@...hat.com>
Subject: Re: linux-next: Tree for Jan 20 -- Kernel panic - Unable to mount
 root fs

On Tue, Jan 20, 2015 at 02:13:09PM -0800, Guenter Roeck wrote:

> > > Nuts...  Is reverting just this (do_path_lookup()) part of commit sufficient
> > > to recover the normal behaviour?
> > 
> > Yes.
> > 
> Same on microblaze.

This is completely insane.
static int filename_lookup(int dfd, struct filename *name,
                                unsigned int flags, struct nameidata *nd)
{
        int retval = path_lookupat(dfd, name->name, flags | LOOKUP_RCU, nd);
        if (unlikely(retval == -ECHILD))
                retval = path_lookupat(dfd, name->name, flags, nd);
        if (unlikely(retval == -ESTALE))
                retval = path_lookupat(dfd, name->name,
                                                flags | LOOKUP_REVAL, nd);

        if (likely(!retval))
                audit_inode(name, nd->path.dentry, flags & LOOKUP_PARENT);
        return retval;
}
doesn't look at _anything_ other than name->name other than for audit_inode().
And name->name is apparently the same.

It looks like something ends up buggering name->name in process, but then
the damn thing appears to be normal after return from filename_lookup()...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/