linux-kernel - Re: [PATCH 7/8] module: add core_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vbk2atx1.fsf@rustcorp.com.au>
Date:	Tue, 20 Jan 2015 16:13:38 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Luis R . Rodriguez" <mcgrof@...e.com>, Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Olof Johansson <olof@...om.net>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Subject: Re: [PATCH 7/8] module: add core_param_unsafe

Dmitry Torokhov <dmitry.torokhov@...il.com> writes:
> Similarly to module_param_unsafe(), add the helper to be used by core
> code wishing to expose unsafe debugging or testing parameters that taint
> the kernel when set.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks,
Rusty.

> ---
>  include/linux/moduleparam.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> index 1392370..6480dca 100644
> --- a/include/linux/moduleparam.h
> +++ b/include/linux/moduleparam.h
> @@ -310,6 +310,15 @@ static inline void __kernel_param_unlock(void)
>  #define core_param(name, var, type, perm)				\
>  	param_check_##type(name, &(var));				\
>  	__module_param_call("", name, &param_ops_##type, &var, perm, -1, 0)
> +
> +/**
> + * core_param_unsafe - same as core_param but taints kernel
> + */
> +#define core_param_unsafe(name, var, type, perm)		\
> +	param_check_##type(name, &(var));				\
> +	__module_param_call("", name, &param_ops_##type, &var, perm,	\
> +			    -1, KERNEL_PARAM_FL_UNSAFE)
> +
>  #endif /* !MODULE */
>  
>  /**
> -- 
> 2.2.0.rc0.207.ga3a616c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/