lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Jan 2015 07:18:19 +0000 (UTC) From: Paul Walmsley <paul@...an.com> To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>, bparrot@...com, detheridge@...com, balbi@...com cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, Tony Lindgren <tony@...mide.com>, devicetree@...r.kernel.org, LAK <linux-arm-kernel@...ts.infradead.org>, OMAP <linux-omap@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/5] ARM: AM43xx: hwmod: add VPFE hwmod entries Hi On Thu, 18 Dec 2014, Lad, Prabhakar wrote: > From: Benoit Parrot <bparrot@...com> > > this patch adds VPFE HWMOD data for AM43xx. > > Signed-off-by: Benoit Parrot <bparrot@...com> > Signed-off-by: Darren Etheridge <detheridge@...com> > Signed-off-by: Felipe Balbi <balbi@...com> > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com> ... > --- > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 56 ++++++++++++++++++++++++++++++ > arch/arm/mach-omap2/prcm43xx.h | 3 +- > 2 files changed, 58 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > index fea01aa..bd9067e 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c ... > @@ -750,6 +788,22 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = { > .user = OCP_USER_MPU | OCP_USER_SDMA, > }; > > +static struct omap_hwmod_ocp_if am43xx_l3__vpfe0 = { > + .master = &am33xx_l3_main_hwmod, > + .slave = &am43xx_vpfe0_hwmod, > + .clk = "l3_gclk", > + .flags = OCPIF_SWSUP_IDLE, > + .user = OCP_USER_MPU, > +}; > + > +static struct omap_hwmod_ocp_if am43xx_l3__vpfe1 = { > + .master = &am33xx_l3_main_hwmod, > + .slave = &am43xx_vpfe1_hwmod, > + .clk = "l3_gclk", > + .flags = OCPIF_SWSUP_IDLE, > + .user = OCP_USER_MPU, > +}; > + > static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { > &am33xx_l4_wkup__synctimer, > &am43xx_l4_ls__timer8, > @@ -848,6 +902,8 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = { > &am43xx_l4_ls__dss, > &am43xx_l4_ls__dss_dispc, > &am43xx_l4_ls__dss_rfbi, > + &am43xx_l3__vpfe0, > + &am43xx_l3__vpfe1, > NULL, > }; According to SPRUHL7 Figure 14-1 "VPFE Integration" and Table 14-2 "VPFE Connectivity Attributes", a VPFE has two interconnect ports per instance: one L4-Per port as a register target, and one L3 port as a DMA initiator. It's unclear to me whether the L3 port can also serve as a register target, but Section 2.1 "ARM Cortex-A9 Memory Map", Table 4-1 "L3 Master-Slave Connectivity", and Figure 4-2 "L4 Topology" suggest that it cannot. So if that's correct, there should be two more struct omap_hwmod_ocp_if records added in this patch for the register target ports that are connected to the L4. DSS is a good example: see am43xx_dss__l3_main and am43xx_l4_ls__dss in this same file. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists