linux-kernel - Re: [PATCH 0/2] x86: earlyprintk cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1501201103360.5526@nanos>
Date:	Tue, 20 Jan 2015 11:29:43 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] x86: earlyprintk cleanup

On Mon, 19 Jan 2015, Alexander Kuleshov wrote:

> The following two patches remove unused macro definitions from 
> early_serial_console and early_printk x86 code.

Sigh. These mechanical 'follow the output of some code analyzer'
changes are really horrible.

Why not doing the obvious: Move the duplicated defines into a common
header file and be done with it?

And if you look deeper, then you'll notice that those defines are used
in two other files as well.

What's worse is that the whole set of defines is readily available in
include/uapi/linux/serial_reg.h already (just with different symbols).

So what's the point of these removal patches?

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/