linux-kernel - Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_0oYX-tErXqGi=nNm=Nm-=uW-0vN+4B=-Wsn_sDrycFQA@mail.gmail.com>
Date:	Tue, 20 Jan 2015 11:31:58 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Peter Korsgaard <jacmet@...site.dk>
Subject: Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

Hello Linus

I am waiting from the confirmation of Peter if that is what he really needs.

It seems to me that the code should continue even if there is no
irqdomain created.

If we need to abort if there is no irqdomain I would rather create a
new patch with this change,  since it it is a change of the current
behaviour, so if something explodes the bisect will be easier.

I will attach to this mail a patch.

Regards

On Tue, Jan 20, 2015 at 11:17 AM, Linus Walleij
<linus.walleij@...aro.org> wrote:
> On Sun, Jan 18, 2015 at 12:39 PM, Ricardo Ribalda Delgado
> <ricardo.ribalda@...il.com> wrote:
>
>> Since d621e8bae5ac9c67 (Create of_mm_gpiochip_remove), there is a
>> counterpart for of_mm_gpiochip_add.
>>
>> This patch implements the remove function of the driver making use of
>> it.
>>
>> Cc: Linus Walleij <linus.walleij@...aro.org>
>> Cc: Alexandre Courbot <gnurou@...il.com>
>> Cc: Peter Korsgaard <jacmet@...site.dk>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>
> Waiting for a v2 addressing the issues pointed out by Peter on this
> patch.
>
> Yours,
> Linus Walleij



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/