linux-kernel - Re: [PATCH 03/14] mfd: intel_soc_pmic: Constify struct regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120115630.GN13701@x1>
Date:	Tue, 20 Jan 2015 11:56:30 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/14] mfd: intel_soc_pmic: Constify struct regmap_config

On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:

> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
>  drivers/mfd/intel_soc_pmic_core.h | 2 +-
>  drivers/mfd/intel_soc_pmic_crc.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.h b/drivers/mfd/intel_soc_pmic_core.h
> index 33aacd9baddc..9498d6719847 100644
> --- a/drivers/mfd/intel_soc_pmic_core.h
> +++ b/drivers/mfd/intel_soc_pmic_core.h
> @@ -23,7 +23,7 @@ struct intel_soc_pmic_config {
>  	unsigned long irq_flags;
>  	struct mfd_cell *cell_dev;
>  	int n_cell_devs;
> -	struct regmap_config *regmap_config;
> +	const struct regmap_config *regmap_config;
>  	struct regmap_irq_chip *irq_chip;
>  };
>  
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index c85e2ecb868a..4cc1b324e971 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -111,7 +111,7 @@ static struct mfd_cell crystal_cove_dev[] = {
>  	},
>  };
>  
> -static struct regmap_config crystal_cove_regmap_config = {
> +static const struct regmap_config crystal_cove_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/