linux-kernel - Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2015 13:53:05 +0100
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	kyungmin.park@...sung.com, b.zolnierkie@...sung.com, pavel@....cz,
	cooloney@...il.com, rpurdie@...ys.net, sakari.ailus@....fi,
	s.nawrocki@...sung.com, Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding
 related macros

On 01/20/2015 12:12 PM, Lee Jones wrote:
> On Fri, 09 Jan 2015, Jacek Anaszewski wrote:
>
>> Add macros for max77693 led part related binding.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Cc: Chanwoo Choi <cw00.choi@...sung.com>
>> ---
>>   include/dt-bindings/mfd/max77693.h |   21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>   create mode 100644 include/dt-bindings/mfd/max77693.h
>>
>> diff --git a/include/dt-bindings/mfd/max77693.h b/include/dt-bindings/mfd/max77693.h
>> new file mode 100644
>> index 0000000..f53e197
>> --- /dev/null
>> +++ b/include/dt-bindings/mfd/max77693.h
>> @@ -0,0 +1,21 @@
>> +/*
>> + * This header provides macros for MAX77693 device binding
>> + *
>> + * Copyright (C) 2014, Samsung Electronics Co., Ltd.
>> + *
>> + * Author: Jacek Anaszewski <j.anaszewski@...sung.com>
>> + */
>> +
>> +#ifndef __DT_BINDINGS_MAX77693_H__
>> +#define __DT_BINDINGS_MAX77693_H
>> +
>> +/* External trigger type */
>> +#define MAX77693_LED_TRIG_TYPE_EDGE	0
>> +#define MAX77693_LED_TRIG_TYPE_LEVEL	1
>> +
>> +/* Boost modes */
>> +#define MAX77693_LED_BOOST_OFF		0
>> +#define MAX77693_LED_BOOST_ADAPTIVE	1
>> +#define MAX77693_LED_BOOST_FIXED	2
>> +
>> +#endif /* __DT_BINDINGS_MAX77693_H */
>
> These look fairly generic.  Do generic LED defines already exist?  If
> not, can they?

I am not entirely sure that they are generic. Different devices
may define different trigger types for low current LEDs and flash
LEDs. Boost modes could also have different semantics.

Regardless of the above we can consider renaming the file to
include/dt-bindings/leds/max77693.h

Bryan - what is your opinion?

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/