linux-kernel - Re: [PATCH v1 0/4] mfd: reorganize Intel drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150120134857.GK13701@x1>
Date:	Tue, 20 Jan 2015 13:48:57 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v1 0/4] mfd: reorganize Intel drivers

On Thu, 11 Dec 2014, Andy Shevchenko wrote:

> This patchset creates a new folder under drivers/mfd and moves there Intel
> related drivers.
> 
> There is no functional change. The names of the kernel configuration variables
> are kept the same.

Can you explain to me why you think the Intel drivers need their own
sub-directory please?

> Andy Shevchenko (4):
>   mfd: change a layout for the Intel related drivers
>   mfd: intel/lpc/sch: move driver to dedicated folder
>   mfd: intel/lpc/ich: move driver to dedicated folder
>   mfd: intel/pmic: move driver to dedicated folder
> 
>  .../platform/intel-mid/device_libs/platform_msic.c |  2 +-
>  .../intel-mid/device_libs/platform_msic_audio.c    |  2 +-
>  .../intel-mid/device_libs/platform_msic_battery.c  |  2 +-
>  .../intel-mid/device_libs/platform_msic_gpio.c     |  2 +-
>  .../intel-mid/device_libs/platform_msic_ocd.c      |  2 +-
>  .../device_libs/platform_msic_power_btn.c          |  2 +-
>  .../intel-mid/device_libs/platform_msic_thermal.c  |  2 +-
>  drivers/acpi/pmic/intel_pmic_crc.c                 |  2 +-
>  drivers/gpio/gpio-crystalcove.c                    |  2 +-
>  drivers/gpio/gpio-ich.c                            |  2 +-
>  drivers/gpio/gpio-msic.c                           |  2 +-
>  drivers/mfd/Kconfig                                | 42 ++--------------------
>  drivers/mfd/Makefile                               |  6 +---
>  drivers/mfd/intel/Kconfig                          | 19 ++++++++++
>  drivers/mfd/intel/Makefile                         |  9 +++++
>  drivers/mfd/intel/lpc/Kconfig                      | 17 +++++++++
>  drivers/mfd/intel/lpc/Makefile                     |  2 ++
>  drivers/mfd/{lpc_ich.c => intel/lpc/ich.c}         | 10 ++----
>  drivers/mfd/{lpc_sch.c => intel/lpc/sch.c}         |  2 +-
>  drivers/mfd/intel/mid/Kconfig                      |  8 +++++
>  drivers/mfd/intel/mid/Makefile                     |  1 +
>  drivers/mfd/{intel_msic.c => intel/mid/msic.c}     |  2 +-
>  .../{intel_soc_pmic_core.c => intel/pmic_core.c}   |  7 ++--
>  .../{intel_soc_pmic_core.h => intel/pmic_core.h}   |  2 +-
>  .../mfd/{intel_soc_pmic_crc.c => intel/pmic_crc.c} |  7 ++--
>  drivers/platform/x86/intel_mid_powerbtn.c          |  2 +-
>  drivers/platform/x86/intel_mid_thermal.c           |  2 +-
>  drivers/watchdog/iTCO_wdt.c                        |  2 +-
>  include/linux/mfd/{lpc_ich.h => intel/ich.h}       |  6 +---
>  include/linux/mfd/{intel_msic.h => intel/msic.h}   |  2 +-
>  .../linux/mfd/{intel_soc_pmic.h => intel/pmic.h}   |  0
>  31 files changed, 90 insertions(+), 80 deletions(-)
>  create mode 100644 drivers/mfd/intel/Kconfig
>  create mode 100644 drivers/mfd/intel/Makefile
>  create mode 100644 drivers/mfd/intel/lpc/Kconfig
>  create mode 100644 drivers/mfd/intel/lpc/Makefile
>  rename drivers/mfd/{lpc_ich.c => intel/lpc/ich.c} (98%)
>  rename drivers/mfd/{lpc_sch.c => intel/lpc/sch.c} (99%)
>  create mode 100644 drivers/mfd/intel/mid/Kconfig
>  create mode 100644 drivers/mfd/intel/mid/Makefile
>  rename drivers/mfd/{intel_msic.c => intel/mid/msic.c} (99%)
>  rename drivers/mfd/{intel_soc_pmic_core.c => intel/pmic_core.c} (97%)
>  rename drivers/mfd/{intel_soc_pmic_core.h => intel/pmic_core.h} (94%)
>  rename drivers/mfd/{intel_soc_pmic_crc.c => intel/pmic_crc.c} (96%)
>  rename include/linux/mfd/{lpc_ich.h => intel/ich.h} (81%)
>  rename include/linux/mfd/{intel_msic.h => intel/msic.h} (99%)
>  rename include/linux/mfd/{intel_soc_pmic.h => intel/pmic.h} (100%)
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/